Skip to content

#127 - Add tests files into contents #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2021
Merged

Conversation

Jeckerson
Copy link
Member

Hello!

  • Type: code quality

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Thanks

@Jeckerson Jeckerson self-assigned this Sep 18, 2021
@Jeckerson
Copy link
Member Author

/cc @remicollet

@Jeckerson Jeckerson linked an issue Sep 18, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 18, 2021

Codecov Report

Merging #128 (144938c) into development (c2436fc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #128   +/-   ##
============================================
  Coverage        75.79%   75.79%           
============================================
  Files                5        5           
  Lines             2954     2954           
============================================
  Hits              2239     2239           
  Misses             715      715           
Flag Coverage Δ
unittests 75.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2436fc...144938c. Read the comment docs.

@remicollet
Copy link

LGTM

@Jeckerson Jeckerson merged commit b46ec38 into development Sep 18, 2021
@Jeckerson Jeckerson deleted the #127-pecl-tests branch September 18, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please provides tests in the pecl archive
2 participants